Closed ba2tro closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
fdcbe41
) 74.98% compared to head (427e079
) 71.11%. Report is 9 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It seems this is completely independent from #86 , right? I should be able to merge it shortly
This looks pretty good. I left some minor comments.
An example based on this should be added to the examples folder as well.
The findmin and findmax that were used in findswappablequbits do not make sense if we are not in a 1D chain, so they should also be parameterized. I think I did that correctly. Please review my changes, fix any issues that I have introduced to make the tests pass again and merge without waiting for me. The "Downgrade" is failing due to unrelated issues.
The argmin
and argmax
return the argument directly, whereas, we were indexing the result from findmin
and findmax
earlier. I have reverted that change as the random_index
function also required indexing. Let me know if we should stick with argmin
and argmax
, I'll change the random_index
to something like random_arg
.
The
argmin
andargmax
return the argument directly, whereas, we were indexing the result fromfindmin
andfindmax
earlier.
julia> argmax([20,10,30])
3
It returns an index, not the argument itself. Am I getting something wrong?
check the commit I added for some small cleanup changes I made
Following #85, here, an entanglement simulation is implemented on a grid that runs
EntanglerProt
andSwapperProt
only on the diagonal