Closed apkille closed 1 month ago
The failed tests seem to come from the recent bumped compat for TermInterface #52, although most recent docs (https://juliasymbolics.github.io/TermInterface.jl/dev/) say that implementing sorted_arguments
is optional.
MethodError: no method matching sorted_arguments(::QuantumSymbolics.STrace)
│
│ Closest candidates are:
│ sorted_arguments(::SymbolicUtils.PolyForm)
│ @ SymbolicUtils ~/.julia/packages/SymbolicUtils/dtCid/src/polyform.jl:235
│ sorted_arguments(::SymbolicUtils.BasicSymbolic)
│ @ SymbolicUtils ~/.julia/packages/SymbolicUtils/dtCid/src/types.jl:119
Attention: Patch coverage is 89.05109%
with 15 lines
in your changes missing coverage. Please review.
Project coverage is 74.23%. Comparing base (
c9d8eed
) to head (9f05adb
).
Files | Patch % | Lines |
---|---|---|
src/QSymbolicsBase/basic_superops.jl | 59.09% | 9 Missing :warning: |
src/QSymbolicsBase/linalg.jl | 91.54% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Just so that I do not get lost, could you point out in this comment thread what are the fixes for #53 and #54? And the corresponding test?
For the spellchecker issue, BA
can be whitelisted in https://github.com/QuantumSavory/QuantumSymbolics.jl/blob/main/.typos.toml
I marked this PR as a draft because I first want to clean up the scaling and flattening functions, and also implement a qexpand
function for expanding quantum expressions. Since this PR adds a lot of features, I would like to submit these changes in a separate PR.
The downstream buildkite error is known and unrelated.
Just FYI, QuantumInterface.jl provides some basis checking foundations and error types: https://github.com/qojulia/QuantumInterface.jl/blob/main/src/bases.jl#L140-L180
Added trace and partial trace functionalities with examples and tests. Also created a symbolic superoperator
SSuperOperator
, including an option to express instances of this composite type in the Kraus representation with the functionkraus
. Future work can be done to create additional superoperator representations and conversions between each of them.In the process of developing this branch, I encountered a few bugs mentioned in #53 and #54, which I fix in this PR.