Closed apkille closed 1 month ago
Attention: Patch coverage is 71.42857%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 73.70%. Comparing base (
4d28a97
) to head (975c44b
).
Files | Patch % | Lines |
---|---|---|
src/QSymbolicsBase/QSymbolicsBase.jl | 71.42% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
the tests are not failing and this is pretty darn fundamental to the library, so it must be good to merge. Feel free to merge as you find appropriate
Originates from discussion in #62. The
withmetadata
macro is designed to add a metadata dict to certain struct definitions. Currently, it is unnecessarily messy and hard to read because it doesn't make use of any pattern-matching packages. This PR makes use of tools from MacroTools.jl to clean up the macro.