qizhou
commented
2 years ago What is the test plan?
The main concern is performance.
BenchmarkHashimotoLight-8 1306 971743 ns/op 18704 B/op 268 allocs/opThis benchmark shows each HashimotoLight took about 1ms. Maybe enough for our case? If not we can further optimize it by using HashimotoFull.
Before actually doing integration test, we also need to add support for this new mask type in storage.
If the maximum gas limit is 50e6, then 50e6 / 1306 = 38284, which is close to our target as 35000. So I think it should be fine.
The main concern is performance.
This benchmark shows each HashimotoLight took about 1ms. Maybe enough for our case? If not we can further optimize it by using HashimotoFull.
Before actually doing integration test, we also need to add support for this new mask type in storage.