QuarkChain / pyquarkchain

Python implementation of QuarkChain
https://quarkchain.io
MIT License
224 stars 114 forks source link

display holders sorted by amount #670

Open qizhou opened 5 years ago

ninjaahhh commented 5 years ago

something like https://etherscan.io/accounts ?

qizhou commented 5 years ago

Exactly.

On Tue, Aug 6, 2019 at 11:11 AM ninjaahhh notifications@github.com wrote:

something like https://etherscan.io/accounts ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/QuarkChain/pyquarkchain/issues/670?email_source=notifications&email_token=AATMNZVYXZYO56U5X234VY3QDG5ELA5CNFSM4IIYSES2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3V74VI#issuecomment-518782549, or mute the thread https://github.com/notifications/unsubscribe-auth/AATMNZRJWDQSCK3TGSNGEYDQDG5ELANCNFSM4IIYSESQ .

ninjaahhh commented 5 years ago

I'm worried more and more extra information will be needed in the future (such as internal transfers inside contracts, miner -> mined blocks indexing, etc), and putting them all into the indexer node's code seems unnecessary.

I think we should at one point fork current pyquarkchain and make code changes separately to fully instrument whatever information we want, without affecting current core business logic