Open 123abcpp opened 6 months ago
thanks for doing clear commit messages. To be picky, perhaps consider using conventional commit messages, that is, use
SEV-SNP: does xyz
instead of
[SEV-SNP]Does xyz
I see, will reword them later.
there are a lot of redundant spaces in the code (red blocks), I think they were added from previous cc commits. Consider clearing them towards the end.
there are a lot of redundant spaces in the code (red blocks), I think they were added from previous cc commits. Consider clearing them towards the end.
fixed
On Thu May 23, 2024 at 1:03 PM CEST, Tianhao Wang wrote:
@shrik3 commented on this pull request.
@@ -3021,8 +3021,11 @@ impl MemoryDef { const GUEST_HOST_SHARED_HEAP_OFFEST: u64 = MemoryDef::GUEST_PRIVATE_HEAP_END; const GUEST_HOST_SHARED_HEAP_END: u64 = MemoryDef::GUEST_HOST_SHARED_HEAP_OFFEST + MemoryDef::GUEST_HOST_SHARED_HEAP_SIZE;
- const GHCB_OFFSET: u64 = MemoryDef::GUEST_HOST_SHARED_HEAP_OFFEST + MemoryDef::PAGE_SIZE*2;
- const HYPERCALL_PARA_PAGE_OFFSET :u64 = MemoryDef::GUEST_HOST_SHARED_HEAP_OFFEST + MemoryDef::PAGE_SIZE*3;
- // Reuse RDMA area for sev-snp special pages
it was commented elsewhere that RDMA stuffs are not supported under cc context. I have missed it then. Sorry for the noise=)
thanks for doing clear commit messages. To be picky, perhaps consider using conventional commit messages, that is, use
instead of