QuarkContainer / Quark

A secure container runtime with CRI/OCI interface

Apache License 2.0

324 stars 49 forks source link

Closed chl337 closed 3 months ago

chl337 commented 3 months ago

1337

P.S. @mhomidi

shrik3 commented 3 months ago

btw I don't see why the context_swap abi has to provide 1 and 0 through parameters. Can't we just use asm literals?

chl337 commented 3 months ago

btw I don't see why the context_swap abi has to provide 1 and 0 through parameters. Can't we just use asm literals?

I don't know if @QuarkContainer has a plan for

    pub fn context_swap(_fromCxt: u64, _toCtx: u64, _one: u64, _zero: u64);

Otherwise, I could drop the two last arguments.

QuarkContainer commented 3 months ago

@chl337 I have no plan for that. Please go ahead to drop those.

QuarkContainer commented 3 months ago

@chl337 is that ok to merge this before your new fix?

chl337 commented 3 months ago

I guess so... Unfortunately, I will not be active till 16/17.08

Cheers