deleting credit crashes Chartbuilder

[golfecholima]

Console error:

Uncaught TypeError: Cannot read property 'shift' of undefined

r.createClass._markdownToTspans @ main.js:21
r.createClass.render @ main.js:21
x._renderValidatedComponentWithoutOwnerOrContext @ main.js:12
x._renderValidatedComponent @ main.js:12
o @ main.js:14
x._updateRenderedComponent @ main.js:12
x._performComponentUpdate @ main.js:12
x.updateComponent @ main.js:12
o @ main.js:14
x.receiveComponent @ main.js:12
i.receiveComponent @ main.js:15
x._updateRenderedComponent @ main.js:12
x._performComponentUpdate @ main.js:12
x.updateComponent @ main.js:12
o @ main.js:14
x.receiveComponent @ main.js:12
i.receiveComponent @ main.js:15
c.updateChildren @ main.js:11
b.Mixin._reconcilerUpdateChildren @ main.js:14
b.Mixin._updateChildren @ main.js:14
b.Mixin.updateChildren @ main.js:14
x.Mixin._updateDOMChildren @ main.js:12
x.Mixin.updateComponent @ main.js:12
x.Mixin.receiveComponent @ main.js:12
i.receiveComponent @ main.js:15
x._updateRenderedComponent @ main.js:12
x._performComponentUpdate @ main.js:12
x.updateComponent @ main.js:12
o @ main.js:14
x.receiveComponent @ main.js:12
i.receiveComponent @ main.js:15
c.updateChildren @ main.js:11
b.Mixin._reconcilerUpdateChildren @ main.js:14
b.Mixin._updateChildren @ main.js:14
b.Mixin.updateChildren @ main.js:14
x.Mixin._updateDOMChildren @ main.js:12
x.Mixin.updateComponent @ main.js:12
x.Mixin.receiveComponent @ main.js:12
i.receiveComponent @ main.js:15
c.updateChildren @ main.js:11
b.Mixin._reconcilerUpdateChildren @ main.js:14
b.Mixin._updateChildren @ main.js:14
b.Mixin.updateChildren @ main.js:14
x.Mixin._updateDOMChildren @ main.js:12
x.Mixin.updateComponent @ main.js:12
x.Mixin.receiveComponent @ main.js:12
i.receiveComponent @ main.js:15
x._updateRenderedComponent @ main.js:12
x._performComponentUpdate @ main.js:12
x.updateComponent @ main.js:12
o @ main.js:14
x.receiveComponent @ main.js:12
i.receiveComponent @ main.js:15
c.updateChildren @ main.js:11
b.Mixin._reconcilerUpdateChildren @ main.js:14
b.Mixin._updateChildren @ main.js:14
b.Mixin.updateChildren @ main.js:14
x.Mixin._updateDOMChildren @ main.js:12
x.Mixin.updateComponent @ main.js:12
x.Mixin.receiveComponent @ main.js:12
i.receiveComponent @ main.js:15
c.updateChildren @ main.js:11
b.Mixin._reconcilerUpdateChildren @ main.js:14
b.Mixin._updateChildren @ main.js:14
b.Mixin.updateChildren @ main.js:14
x.Mixin._updateDOMChildren @ main.js:12
x.Mixin.updateComponent @ main.js:12
x.Mixin.receiveComponent @ main.js:12
i.receiveComponent @ main.js:15
c.updateChildren @ main.js:11
b.Mixin._reconcilerUpdateChildren @ main.js:14
b.Mixin._updateChildren @ main.js:14
b.Mixin.updateChildren @ main.js:14
x.Mixin._updateDOMChildren @ main.js:12
x.Mixin.updateComponent @ main.js:12
x.Mixin.receiveComponent @ main.js:12
i.receiveComponent @ main.js:15
x._updateRenderedComponent @ main.js:12
x._performComponentUpdate @ main.js:12
x.updateComponent @ main.js:12
o @ main.js:14
x.performUpdateIfNecessary @ main.js:12
i.performUpdateIfNecessary @ main.js:15
s @ main.js:15
a.perform @ main.js:16
a.perform @ main.js:16
g.perform @ main.js:15
N @ main.js:15
o @ main.js:14
a.closeAll @ main.js:16
a.perform @ main.js:16
p.batchedUpdates @ main.js:13
i @ main.js:15
v.dispatchEvent @ main.js:14

[nsonnad]

Looks like this is an issue with trying to parse markdown even when there is no input. @yanofsky I've got a fix in #206 but not sure if that covers all cases

(Sorry about the vim whitespace noise, the line is question is this one)

[golfecholima]

FWIW I discovered this when adding subtitle. I had tried to populate head/sub with some initial TK boilerplate text. Doing so caused crashes if the text was completely removed from any field.

[nsonnad]

The fix has been merged. Look good to you @golfecholima ?

[golfecholima]

Yup! Worked on two different builds I updated. Thanks @nsonnad.