adds aws-publish task for deploying to S3

Quartz / Chartbuilder

A front-end charting application that facilitates easy creation of simple beautiful charts

http://quartz.github.io/Chartbuilder

MIT License

2.1k stars 354 forks source link

adds aws-publish task for deploying to S3 #249

Closed bradoyler closed 8 years ago

bradoyler commented 8 years ago

For deploying to AWS S3 😸 #246 cc: @nsonnad @yanofsky

Instructions:

$ cp config.json.example config.json
populate config.json file with your S3 options/creds.
$ gulp publish

console output:

[21:21:52] Using gulpfile ~/projects/Chartbuilder/gulpfile.js
[21:21:52] Starting 'publish'...
[21:21:55] [create] cdnassets/chartbuilder/index.html
[21:21:56] [create] cdnassets/chartbuilder/css/main.css
[21:21:59] [create] cdnassets/chartbuilder/js/main.js
[21:21:59] Finished 'publish' after 6.09 s

bradoyler commented 8 years ago

@yanofsky Any objections?

nsonnad commented 8 years ago

Thanks @bradoyler! One thing, shouldn't the publish task require the build task to be completed first? Eg

gulp.task('publish', ['build'], function() { ... })

bradoyler commented 8 years ago

That's prolly a good idea. Although I always run build first anyway.

bradoyler commented 8 years ago

@nsonnad cool to merge now? Then I'll get cracking on #165 😈

nsonnad commented 8 years ago

Hey Brad, thanks. I made a couple minor changes here https://github.com/Quartz/Chartbuilder/pull/252 (sorry to create a new PR, but github won't let me edit your filez)

moved/renamed gulp/aws-config.json -- was a bit confusing to have multiple config files.
added an npm script so that you can npm run aws and don't need global gulp
added some docs.

Can you verify that that is all good, and if so, we can merge it in. Thanks again!

bradoyler commented 8 years ago

close in favor of #252