search

Quartz / wp-graphql-content-blocks

Structured content blocks for WPGraphQL
76 stars 16 forks source link

core quote block is missing cite tag #10

Closed dalecreativ closed 3 years ago

dalecreativ commented 3 years ago

Hello,

Thanks for creating this plugin, it's been super useful for a current project.

I was looking for some help, or to make a request to handle the core/quote block cite tags.

When using the plugin the innerHtml of the quote block seems to remove the cite tag, but it keeps the inner text from the cite tag. When disabling the plugin, or querying against post.content I see the cite tags are there, as expected. When we switch the query to use blocks the cite tags are removed from the innerHtml property again.

Is there anything that can be done to handle this so we can include the correct semantic markup for a blockquote block?

Any help or advice would be much appreciated.

chriszarate commented 3 years ago

Hi!

I think cite was just erroneously omitted from the list of HTML tags.

Quick fix: Add it to this array, e.g.:

'cite' => [
    'root_only' => false,
    'allow_root' => false,
],
dalecreativ commented 3 years ago

Thank you for your quick response @chriszarate.

Is it worth me dropping a PR in for the quick fix above?

chriszarate commented 3 years ago

@dalecreativ Definitely with thanks!

dalecreativ commented 3 years ago

Hi @chriszarate @Bhammy

Should I have bumped a minor version along with the update made last week?