search

Quasars / orange-spectroscopy

Other
52 stars 58 forks source link

Documenting requirements #3

Closed stuart-cls closed 8 years ago

stuart-cls commented 8 years ago

In #1 we introduced the scipy.signal.savgol_filter module, but this was only introduced in scipy version 0.14.0. Ubuntu 14.04 only has 0.13.3.

I can fix this with pip on my box but I'm wondering if we need to be documenting our requirements somewhere.

markotoplak commented 8 years ago

In setup.py there is a call of setup function with a parameter install_requires. It can be set to a list containing elements like this:

'scipy',
'six',
'genesis-pyapi>=1.1.2',
"slumber>=0.7.1",
"requests>=2.6.0"

Generally, any requirement that can be installed with pip and does not conflict with Orange is OK. Such packages will be automatically installed by pip during installation.

In practice there are often problems with installation on Mac and Windows, where most users do not have compilers. We will therefore need to distribute the correct scipy binary with either main Orange installation (that also requires scipy, but lower version is OK, in this case this option is preferable) or with the the add-on build.

stuart-cls commented 8 years ago

Okay, got it. It looks like recent (3.2) versions of Orange install at least scipy 0.15.2 (on Windows) so we are okay so far.

markotoplak commented 8 years ago

Thanks, also on Mac it was OK. I added that requirement into the package.