Quasars / orange-spectroscopy

Other
52 stars 58 forks source link

Peakfit visual feedback #578

Open borondics opened 2 years ago

borondics commented 2 years ago

@stuart-cls, the Peakfit curve updates are not consistent with what I would expect based on the operations in the left panel.

Here is an example when there are two peaks added but the model shows very different stuff.

image

I am also getting questions from users about it.

Parameters are also not updated after the fit but this might be an Orange restriction on backwards data flow? Although the parameters could be dynamically updated based on which spectrum is selected if there are multiple.

stuart-cls commented 2 years ago

About the parameter update, I now agree that's a good idea. Constraints should be locked to the original though, I need to think about how to do that.

In this particular case, the fit seems right to me given there is no amplitude/sigma/center constraints on the purple peak and green amplitude initial value is not within the specified limits. But I think this is also an argument for re-thinking how the limits are presented.

borondics commented 2 years ago

Actually this is a much more complex issue I first thought. Some users (and myself) had problems with the editing of the parameters too, which is unrelated to the display.