search

Quasars / orange-spectroscopy

Other
52 stars 58 forks source link

[FIX] Fix loading pre-0.6.1 workflows with explicit reader settings #600

Closed markotoplak closed 2 years ago

markotoplak commented 2 years ago

We were sloppy in #575. In the owfile settings, explicitly selected readers are stored with the full module and class names. Moving but not adding imports for compatibility showed the missing reader error. I remembered this bug while studying how owfile works.

I also needed to move getx somewhere out of orangecontrib.spectroscopy.data because of circular imports. orangecontrib.spectroscopy.data.util did not work because that still imported the parent module. I am open to better names than orangecontrib.spectroscopy.util.

stuart-cls commented 2 years ago

Whoops! I didn't notice this directly but sometimes strangeness like that gets missed when you're just quickly loading an old workflow to show someone.

I won't have time to test but it looks sensible to me. As long as scripts can still use from orangecontrib.spectroscopy.data import getx we should be fine there.