search

Quasars / orange-spectroscopy

Other
52 stars 58 forks source link

[ENH] PyQt6 and Python 3.10 support #649

Closed markotoplak closed 1 year ago

markotoplak commented 1 year ago

I tested Orange-Spectroscopy in a more modern environment and this were the minimum required changes for tests to pass.

Some are due to PyQt6 and some are due to Python 3.10.

It would be cool if some developers would start using these more modern versions because our test do not have perfect coverage so other stuff can go wrong too.

codecov-commenter commented 1 year ago

Codecov Report

Merging #649 (ac86b80) into master (d03d27f) will increase coverage by 0.16%. The diff coverage is 91.83%.

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
+ Coverage   89.33%   89.50%   +0.16%     
==========================================
  Files          71       71              
  Lines       11854    11841      -13     
==========================================
+ Hits        10590    10598       +8     
+ Misses       1264     1243      -21
markotoplak commented 1 year ago

@PrimozGodec, just for context about our discussion today, this is what I had to fix. All minor, but necessary.