search

Quasars / orange-spectroscopy

Other
51 stars 59 forks source link

Standard map vars #654

Closed stuart-cls closed 1 month ago

stuart-cls commented 1 year ago

Working on #615 reminded me of a class of little bugs I've been meaning to address: standard "map_x" / "map_y" variables

First commit replaces all "map_x" / "map_y" strings with constants ~Second commit shows how this can be used to reliably plot XY data in Hyperspectra if both these vars are present (otherwise reverts to existing behaviour.~

~If this works, I'll also apply to the other mapping-aware widgets (Bin, Stack, Polar, etc)~

stuart-cls commented 1 month ago

Based on @borondics comments in #739, I simplified this PR just to focus on the constants. I'll open another to fix the very annoying bug when Hyperspectra plots vs (clusters, map_x) or something

stuart-cls commented 1 month ago

I chose to leave the line-too-long lints.

markotoplak commented 1 month ago

Thanks! I like that you did not aim to standardize the non-standard ones (that would break settings).

stuart-cls commented 1 month ago

One change at a time :)