search

Quasars / orange-spectroscopy

Other
52 stars 58 forks source link

Unify Cut preprocessors #661

Closed borondics closed 6 months ago

borondics commented 1 year ago

Currently the Cut preprocessors come in two flavors: "keep" and "remove". image

As the number of preprocessors are growing it would be nice to unify these two.

The new GUI would be the same with "Low limit" and "High limit" and we could add a radio selector at the bottom to select whether to "keep" or "remove" the part between the limits.

Previous workflows need to be able to run, so backwards compatibility is important.

pisarik commented 1 year ago
  1. Will Select region be a good name for the unified widget?
  2. Do you think the new widget could also allow to keep and remove several regions? It could be quite handy, since now the "keep" widget cannot be used twice and therefore when you want to keep two regions, you actually need to remove three regions. It also feels clumsy to create the cut widget three times.
borondics commented 1 year ago

We could call it "butcher data". OK, that was a joke.

I think we should keep "Cut" because of backward compatibility (the new preprocessor needs to also handle both old widgets) and the understanding of the users who are familiar with "Cut". So, if we keep the name but improve the functionality with joining "Cut - remove" and "Cut - keep" that would be my preference.

Adding the capability of multiple regions would be great!

markotoplak commented 6 months ago

Fixed in #661