Quasars / orange-spectroscopy

Other
52 stars 58 forks source link

[ENH] Spectra: waterfall plot #666

Closed markotoplak closed 1 year ago

markotoplak commented 1 year ago

An option to show spectra in a stacked form. For now we do not have parameters how much to move the spectra. but that can be added later.

stuart-cls commented 1 year ago

Sorry to review this after you merged it!

This does not do what I expected. If I take the collagen dataset, average by type and then plot with this on, I get image

I would expect to get something like this: image

Is this just the parameters to move that you mention?

In any case, I think the default should be more like the second figure, the first is just some kind of weird normalization :)

markotoplak commented 1 year ago

I merged to that it gets more testing. :)

Thanks for looking into this. So we should have a bigger step? For now it is, I think (maxy-miny)*0.1, so like a 10% move. I do think this should become a parameter, but what default would you suggest? Feel free to play with the waterfall_constant and report what works well for you.

borondics commented 12 months ago

Works great!