search

Quasars / orange-spectroscopy

Other
51 stars 58 forks source link

Unify cuts Issue#661 #699

Closed nicholsonbt closed 8 months ago

markotoplak commented 8 months ago

Thanks for the PR!

Failing tests on Win/Mac are not the problem with this PR.

To avoid silent wrongly read new setting on older version of Quasar, I suggest also renaming orangecontrib.spectroscopy.cut. Then, users will be warned when opening a too-new workflow.

nicholsonbt commented 8 months ago

The name is changed from orangecontrib.infrared.cut, but instead of warning the user that a too-new workflow is being opened, it's silently removing the new editors from the preprocessor widget.

Is there an existing function to catch any editors with unknown names and output a warning?

markotoplak commented 8 months ago

The name is changed from orangecontrib.infrared.cut, but instead of warning the user that a too-new workflow is being opened, it's silently removing the new editors from the preprocessor widget.

Ow, that is bad, but if it so then I do not know if there is anything we can do about the (in)compatibility. warning. I'll think about it some more... Thanks!

markotoplak commented 8 months ago

Thanks. I'll make a separate PR which will make out-of-date installations in the future explicit, but can not see anything that can be done here.