search

Quasars / orange-spectroscopy

Other
51 stars 58 forks source link

[FIX] Avoid some context crashes: exclude_attributes=True #707

Closed markotoplak closed 6 months ago

markotoplak commented 6 months ago

Some contexts match even though feature-selection combo boxes do not show the feature. Problematic settings are those where combo boxes are limited to specific parts of the table (attributes, class_vars, or metas).

This partial solution follows from https://github.com/biolab/orange3/issues/6721#issuecomment-1923826563. This does not solve the problem completely, but if problem appears, adding a new widget instance allows the user to continue.

Also, there is another minor issue: exclude_attributes won't allow users to reuse contexts where class vars were used in the fields (current implementation handles attributes and class vars in the same way), but saving and loading works properly (because of perfect matches).

markotoplak commented 6 months ago

Partial solution to #706.

markotoplak commented 6 months ago

This does not fix crashes that appear if the user chose a class variable in the boxes (I tried by coloring Iris data in Spectra), because attributes and classes are handled in a package.

That would have to be fixed by making a new context handler.