search

Quasars / orange-spectroscopy

Other
51 stars 58 forks source link

[FIX] Disable __eq__ and __hash__ because it can be slow #713

Closed markotoplak closed 5 months ago

markotoplak commented 5 months ago

It can be so slow that it appears Orange has crashed.

With @borondics we had a workshop in Berlin and preprocessing appeared to crash for most students. We thus downgraded to a previous version.

After debugging I saw that a series of preprocessors causes domain comparisons to be very long (for example, after normalization, each feature in turn references the whole original domain, and then equality checking just multiplies).

markotoplak commented 5 months ago

I intend to merge this and re-release.

codecov[bot] commented 5 months ago

Codecov Report

Merging #713 (40bed24) into master (ff7c581) will decrease coverage by 0.39%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #713 +/- ## ========================================== - Coverage 88.53% 88.15% -0.39% ========================================== Files 73 73 Lines 12613 12613 ========================================== - Hits 11167 11119 -48 - Misses 1446 1494 +48 ```