search

Quasars / orange-spectroscopy

Other
51 stars 59 forks source link

Multifile test crashing on latest Orange #746

Closed markotoplak closed 3 weeks ago

markotoplak commented 4 weeks ago

On the latest Orange version some Multifiles tests are crashing. This should be investigated before the next release.

stuart-cls commented 3 weeks ago

It's from this commit: https://github.com/biolab/orange-widget-base/commit/511f4be4a5e8d52d0f3852192d49973229bdb56c#diff-88d809289fc4b688675211f4efadb60dc3ef607c252dd9f6d99611ffa3b6f6e3

stuart-cls commented 3 weeks ago

I guess something about the way that TestOWMultifile.test_spectra_almost_same_wavenumbers is patching the SPAReader and updating the FileFormat cache after widget instantation? The open_filename_dialog logic is almost identical with the default value as used in OWMultifile.