search

QuazarTech / DG_Maxwell

Solution of Maxwell equations using Discontinuous Galerkin method.
GNU General Public License v3.0
9 stars 5 forks source link

Travis build failing when af.inverse is being used #62

Open Balavarun5 opened 7 years ago

Balavarun5 commented 7 years ago

Commit : 3f71b025a55af50e4383aeaedb8d8f2178efd038

Issue

The Travis build for the PR #59 is failing for the test_advection() test function, This test_advection() function uses af.inverse()

amanabt commented 7 years ago

@Balavarun5 First, give the full address of the test function, dg_maxwell/tests/test_waveEqn.py::test_advection. Second, PR #59 is for 2D advection solver only, test_advection is a part of 1D advection solver. So, this function should not be written in this PR. Please create a different PR and work on it there.

Balavarun5 commented 7 years ago

This test should be there regardless, It's similar to testing a primary function like 1D A-matrix, volume integral term and the surface term.

amanabt commented 7 years ago

I agree that we may build upon the results of this test for 2D advection solver. But that does not explain why this function should be developed in this PR. Let's not make the mistake again of creating huge PR's with many different additions and merging them at once. This only makes the PR confusing.

Balavarun5 commented 7 years ago

A PR #63 for this issue has been created