search

QubesOS / qubes-issues

The Qubes OS Project issue tracker
https://www.qubes-os.org/doc/issue-tracking/
541 stars 48 forks source link

qubes-hcl-report doesn't properly escape spaces in machine name #1994

Closed marmarek closed 8 years ago

marmarek commented 8 years ago

There is expression meant to replace non-alphanumeric characters with underscore, but apparently it doesn't work: https://github.com/QubesOS/qubes-core-admin/blob/master/qvm-tools/qubes-hcl-report#L106

FILENAME="Qubes-HCL-${BRAND//+([^[:alnum:]])/_}-${PRODUCT//+([^[:alnum:]])/_}-$DATE"

According to bash manual it should be ok. And it works on bash 4.3.42, but not on 4.2.53 which we have in dom0. Some bash bug?

Reported by picard

unman commented 8 years ago

What about this? FILENAME="Qubes-HCL-${BRAND//[^[:alnum:]]/_}-${PRODUCT//[^[:alnum:]]/_}-$DATE"

marmarek commented 8 years ago

Yes, I have exactly this already committed, just not pushed yet.

marmarek commented 8 years ago

Automated announcement from builder-github

The package qubes-core-dom0-3.1.17-1.fc20 has been pushed to the r3.1 testing repository for dom0. To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

marmarek commented 8 years ago

Automated announcement from builder-github

The package qubes-core-dom0-3.1.17-1.fc20 has been pushed to the r3.1 stable repository for dom0. To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update