search

QubesOS / qubes-issues

The Qubes OS Project issue tracker
https://www.qubes-os.org/doc/issue-tracking/
544 stars 48 forks source link

/bin/qubes-dom0-update: lime 251: [: too many arguments #5901

Closed rjt closed 4 years ago

rjt commented 4 years ago

Qubes OS version R4.0

Affected component(s) or functionality ReInstalling qubes-template-fedora-31 by: [Dom0 ] sudo qubes-dom0-update —action=reinstall qubes-template-fedora-31

Brief summary ReInstall results in error on line 251 of /bin/qubes-dom0-update

To Reproduce _1. Follow instructions at https://www.qubes-os.org/doc/reinstall-template/ _2. Open terminal in Dom0 _3. sudo qubes-dom0-update —action=reinstall qubes-template-fedora-31 _4. Notice it might look successful with Reinstalled: qubes-template-fedora31.noarch 4.0.1-202002142323

Complete! /bin/qubes-dom0-update: line 251: [: too many arguments

Expected behavior qubes scripts should be able to handle documented number of arguments

Actual behavior Script fails because too many arguments.

Screenshots Additional context Trying to resolve non working qubes and fedora 31.

Solutions you've tried Repeating and rebooting and repeating

Relevant ([documentation]https://www.qubes-os.org/doc/) you've consulted https://www.qubes-os.org/doc/reinstall-template/

Related, non-duplicate issues

3hhh commented 4 years ago

Looks like @fepitre forgot an &&.

https://github.com/QubesOS/qubes-core-admin-linux/commit/df3f29d1dba1d45b2e3941b93ed28ac2f1bbd74b#diff-6b87ee5cdb9e63b703415a14e5a505cdR251

I wonder why ShellCheck didn't catch that.

rjt commented 4 years ago

This time i tried to update the minimal version qubes-template-fedora-31-minimal.

Reminded me that the first attempt has another error line: Total size: 487 M Is this ok [y/N]: Operation Aborted. /bin/qubes-dom0-update: line 251: [: too many arguments

fepitre commented 4 years ago

Looks like @fepitre forgot an &&.

QubesOS/qubes-core-admin-linux@df3f29d#diff-6b87ee5cdb9e63b703415a14e5a505cdR251

I wonder why ShellCheck didn't catch that.

Yes indeed. Running it under vscode integration or manually it does not catch it. Weird...My apologize.

qubesos-bot commented 4 years ago

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.27-1.fc25 has been pushed to the r4.0 testing repository for dom0. To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

qubesos-bot commented 4 years ago

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.27-1.fc25 has been pushed to the r4.0 stable repository for dom0. To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

qubesos-bot commented 4 years ago

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.1.7-1.fc32 has been pushed to the r4.1 testing repository for dom0. To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

qubesos-bot commented 4 years ago

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.1.7-1.fc32 has been pushed to the r4.1 stable repository for dom0. To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update