search

QubesOS / qubes-issues

The Qubes OS Project issue tracker
https://www.qubes-os.org/doc/issue-tracking/
529 stars 46 forks source link

Incorrect message when renaming of qube fails #8256

Open verygreen opened 1 year ago

verygreen commented 1 year ago

Qubes OS release

4.1.2

Brief summary

When renaming a qube (e.g. template) failes because there's disp vm running, a message is printed that outlines the failure. This message lists the qube name three times where clearly one of those occurrences is supposed to list the new desired name.

Screenshot_2023-06-12_00-16-18

Steps to reproduce

Tename a template that has a dispvm running

verygreen commented 1 year ago

The somewhat trivial fix is here: https://github.com/QubesOS/qubes-manager/pull/349

though I guess it does not like my lack of signature?

andrewdavidwong commented 1 year ago

though I guess it does not like my lack of signature?

Would you mind generating a key and using it to sign your code? Instructions are provided here:

https://www.qubes-os.org/doc/code-signing/

verygreen commented 1 year ago

I signed the commit, but it's still unhappy.

andrewdavidwong commented 1 year ago

I signed the commit, but it's still unhappy.

Hmm, did you upload your key to one of the approved keyservers?

verygreen commented 1 year ago

there are references to "A key server", in that code signing document, but no instructions how to do it or what those servers are.

andrewdavidwong commented 1 year ago

It's in this section:

https://www.qubes-os.org/doc/code-signing/#upload-the-key

verygreen commented 1 year ago

sorry, somehow missed it. Should be all good now.

verygreen commented 1 year ago

ha, "Great,", now it failed CI seemingly due to unrelated failure to fetch some fedora updates or some such. is there a way to retrigger the test?

DemiMarie commented 1 year ago

Don’t worry @verygreen, it isn’t your fault :smile:. I just issued a command that will cause all the failed runs to be retried.

andrewdavidwong commented 3 weeks ago

https://github.com/QubesOS/qubes-manager/pull/349 was merged a long time ago, but it says that it fixes https://github.com/QubesOS/qubes-issues/issues/8056, not this issue.

Should this issue still be open?