Creation of a new StandaloneVM/TemplateVM fails during the cloning process

Minimalist73 commented 1 week ago

Qubes OS release

r4.2.3

Brief summary

When creating a new StandaloneVM or TemplateVM that involves cloning, the creation fails with an error and prevents the new qube from being created. Creating a qube of type AppVM works fine.

ERROR: TypeError('QubesBase.clone_vm() takes 3 positional arguments but 4 positional arguments (and 1 keyword-only argument) were given')

Steps to reproduce

Open the qube creation menu (new or old, it doesn't matter)
Select Type: StandaloneVM or TemplateVM
Select template to clone
Network to default
Create qube and get error

Expected behavior

StandaloneVM or TemplateVM is created.

Actual behavior

Ends in error and doesn't create anything.

Minimalist73 commented 1 week ago

Traced back to last week commit @marmarek: https://github.com/QubesOS/qubes-core-admin-client/commit/4df787b5c888343de61fa018ad9398d09a21ee57#diff-35e74c7eb62ebefca8aecf6d3f616cfc110ed62797851516bf86f93034676955R362 Removing the * in the position argument makes the qube creation menu work again.

Edit: Moving * after new_cls seems to work too.

gunduzc commented 1 week ago

I have the exact same problem and I am able to reproduce this with a fresh QubesOS install.

TommyTran732 commented 1 week ago

Making AppVMs work now but TemplateVMs are still broken

QubesOS / qubes-issues