search

QubesOS / qubes-video-companion

MIT License
22 stars 11 forks source link

Export dbus address for the notification server #23

Closed ben-grande closed 5 months ago

ben-grande commented 5 months ago

Only screenshare script requires as of today, but put it in webcam also for future proof as it doesn't cause any harm.

Assigning variable and declaration made separate due to ShellCheck warning SC2155.

For: https://github.com/QubesOS/qubes-issues/issues/6426 Fixes: https://github.com/QubesOS/qubes-issues/issues/8457 Fixes: https://github.com/QubesOS/qubes-video-companion/issues/15

DemiMarie commented 5 months ago

Should $XDG_RUNTIME_DIR also be set?

ben-grande commented 5 months ago

Should $XDG_RUNTIME_DIR also be set?

Not necessary but nice to have and be the base path of DBUS_SESSION_BUS_ADDRESS. Will do.

ben-grande commented 5 months ago

Don't override those unconditionally. Set only if not present already.

Done.

Especially, if user session is running (and so is qrexec-fork-server), they should be provided already. There may be cases when either of them have different value (like in GUI domain that runs full desktop env)

Unfortunately they were not set and many users, including me, encountered that issue. Now it is using the existent value if set, else fallback.