search

QubitProducts / bamboo

HAProxy auto configuration and auto service discovery for Mesos Marathon
Apache License 2.0
794 stars 214 forks source link

In GUI, I can update a empty ACL and destroy haproxy config #119

Closed hyper0x closed 9 years ago

hyper0x commented 9 years ago

I will get the following log if I update a empty ACL:

[ALERT] 106/065607 (51) : parsing [/etc/haproxy/haproxy.cfg:1035] : error detected while parsing switching rule : no such ACL : '::myapp-websocket-aclrule'.

In fact, there are the following parts in haproxy.cfg:

acl ::myapp-websocket-aclrule 
use_backend ::myapp-websocket-cluster if ::myapp-websocket-aclrule

I think that it's not robust.

j1n6 commented 9 years ago

The UI and API needs improvements. When haproxy reload, it should validate whether the content is valid before trigger the reload.

hyper0x commented 9 years ago

I couldn't agree more

lclarkmichalek commented 9 years ago

See #158

lclarkmichalek commented 9 years ago

Template validation is now supported, @hyper-carrot would you like to keep this open for UI ACL validation, or is this good enough for you?

hyper0x commented 9 years ago

@bluepeppers Thank you for reminding, but my central focus have changed. So, I will keep my attention in my spare time. :-)

lclarkmichalek commented 9 years ago

Cool, closing then :+1: