QubitProducts / bamboo

HAProxy auto configuration and auto service discovery for Mesos Marathon
Apache License 2.0
794 stars 214 forks source link

Shell variable bugs in supervisord.conf #145

Closed boomfish closed 9 years ago

boomfish commented 9 years ago

The supervisord.conf files had an incorrect colon in the default for the variable expansion of $CONFIG_PATH. This was most likely due to the adjacent variable $BIND having a default that starts with a colon (:8000). It's also confusing because it looks similar to the alternate ${var:-val} syntax for expanding a variable with a default.

To reduce confusion in the future I changed both variables to use the ${var:-val} syntax which is slightly more robust in this case (it uses the default when the variables is defined as an empty string).

j1n6 commented 9 years ago

Thank you for submit the patch.