Closed gregory90 closed 9 years ago
Would a timeout on reloads be enough?
It would be perfect:)
Hanging HAProxy is likely an issue with the reload command not being correct, thus leading to race conditions. We were experiencing similar issues but got rid of them completely as soon as we used the right reload command. See also my PR #122.
IMHO, the right solution here is to analyze and fix the HAProxy problem and not introduce more complexity into Bamboo.
@timoreimann I've checked my haproxy reload command and it is not the one used in your PR. You're right, timeouts would be last resort solution. Closing for now. I'll reopen if I hit this problem again with new reload command.
I'm running bamboo using docker container. Bamboo won't start another reload while one is pending, but sometimes(very seldom) it happens that haproxy reload hangs forever. Logs: https://gist.github.com/gregory90/dae71eccb927d9cc4019