QubitProducts / bamboo

HAProxy auto configuration and auto service discovery for Mesos Marathon
Apache License 2.0
793 stars 214 forks source link

Use templateData instead of empty interface #169

Closed njuettner closed 8 years ago

njuettner commented 8 years ago

Hi everyone,

I'd like to discuss if it would be better to use templateData instead of an interface, cause it's already given.

As far as I can see there should be no reason not to use it.

The function itself is used by eventhandler and api state.

What do you think guys?

j1n6 commented 8 years ago

I think this is a valid concern. Looks good to me.

lclarkmichalek commented 8 years ago

:fried_shrimp: lgtm

j1n6 commented 8 years ago

@njuettner thank you.