QubitProducts / bamboo

HAProxy auto configuration and auto service discovery for Mesos Marathon
Apache License 2.0
793 stars 214 forks source link

Dockerfile Build Error http.Client Timeout #182

Closed scottbrumley closed 8 years ago

scottbrumley commented 8 years ago

On building with the Dockerfile I'm getting an error message:

github.com/QubitProducts/bamboo

./bamboo.go:185: client.Timeout undefined (type *http.Client has no field or method Timeout)

Scott

lclarkmichalek commented 8 years ago

Is this with master? The recent event streaming feature sets client.Timeout, so we may need to up the minimum Go version.

scottbrumley commented 8 years ago

Yes

scottbrumley commented 8 years ago

Just a git clone https://github.com/QubitProducts/bamboo.git

lowstz commented 8 years ago

Hit this issue too.

adityareddy commented 8 years ago

me too

drdocker commented 8 years ago

+1 ran into this issue as well when following the readme instructions for performing a Docker build. Step 9 fails.

Step 9 : RUN go get github.com/tools/godep &&     go get -t github.com/smartystreets/goconvey &&     go build &&     ln -s /opt/go/src/github.com/QubitProducts/bamboo /var/bamboo &&     mkdir -p /run/haproxy &&     mkdir -p /var/log/supervisor
 ---> Running in e5115840719e
# github.com/QubitProducts/bamboo
./bamboo.go:185: client.Timeout undefined (type *http.Client has no field or method Timeout)
rasputnik commented 8 years ago

Timeout was added to http.Client in Go 1.3, wasn't it?

scottbrumley commented 8 years ago

Looks like an issue with go lang version 1.2 in ubuntu:14.04. So change ubuntu:14.04 in the dockerfile FROM to ubuntu:15.10 and call it a day.

Boran commented 8 years ago

I changed "FROM to ubuntu:15.10 " and now get past the above error, but now have

Step 8 : RUN gem install fpm
 ---> Running in 0ac84ad6abf2
/bin/sh: 1: gem: not found
The command '/bin/sh -c gem install fpm' returned a non-zero code: 127

The fix for that was to add "RUN apt-get install -yqq gem ruby"

scottbrumley commented 8 years ago

Also if you want to stay with ubuntu TLS which is not a bad idea in production. You can also just upgrade go from 1.2 to at least 1.3. Boran that might help if you don't find an easy resolution to ruby.