search

QubitProducts / bamboo

HAProxy auto configuration and auto service discovery for Mesos Marathon
Apache License 2.0
794 stars 215 forks source link

Now using golang:1.6.2 as a base for docker images #206

Closed mvallerie closed 8 years ago

mvallerie commented 8 years ago

Hi there.

As stated in #200 , Go 1.6 may fix some issues. This PR changes the base image in Dockerfiles to switch to golang:1.6.2.

Please note that golang image is based on jessie-scm, so your existing Dockerfiles were mainly compatible with it. GOPATH is /go on golang image, so i had to change this, and i also removed some (apparently ?) unused ppa repositories which would have not been compatible with jessie-scm anyway.

Disclaimer : i tested Dockerfile on our production cluster, works great. But i wasn't able to test Dockerfile-deb. Only a few minor changes, so i assume it won't break anything, but i would feel it safer if someone who uses it everyday could confirm that.

Thanks in adv. !

swagatha-christie commented 8 years ago

By analyzing the blame information on this pull request, we identified @bateau84, @sttts and @rthomas to be potential reviewers

coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.3%) to 39.154% when pulling 23f2741d033c616b2830e21d4bb50eb542fd2104 on mvallerie:master into 01da91b0530ac0a7d2ca4fb4af79e161c25753ea on QubitProducts:master.

j1n6 commented 8 years ago

LGTM.

Sent from my iPhone

On 13 May 2016, at 04:33, Coveralls notifications@github.com wrote:

Coverage increased (+3.3%) to 39.154% when pulling 23f2741 on mvallerie:master into 01da91b on QubitProducts:master.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub