Ignore event lines in event stream.

QubitProducts / bamboo

HAProxy auto configuration and auto service discovery for Mesos Marathon

Apache License 2.0

793 stars 214 forks source link

Ignore event lines in event stream. #225

Closed xperimental closed 7 years ago

xperimental commented 7 years ago

The event stream seems to have three types of "lines":

Empty lines sent in regular interval as "heartbeat"
Lines starting with "event: " containing only the event type
Lines starting with "data: " containing a JSON representation of the event

Currently the "event: " lines produce log output hinting that there was an error while they can be safely ignored (the event type is also present in the JSON).

Fixes #219

swagatha-christie commented 7 years ago

By analyzing the blame information on this pull request, we identified @activars, @bsideup and @g0hacker to be potential reviewers

coveralls commented 7 years ago

Coverage remained the same at 43.694% when pulling d252afe99a9cf0a1bff1183d617c5288fad9d095 on xperimental:ignore-event-lines into 36532e313e4656df591224195d606143ffa05d4d on QubitProducts:master.

bsideup commented 7 years ago

Since Marathon is keep adding the new event types, maybe, instead of filtering, we should change it to: "if starts with "data" then process" ?

xperimental commented 7 years ago

@bsideup Added clarification to the PR description.

bsideup commented 7 years ago

@xperimental with your clarification it makes even more sense then :)

coveralls commented 7 years ago

Coverage increased (+0.1%) to 39.265% when pulling 2ee9e3d01b80ec6bd16ffe6e202e7919a0f447b4 on xperimental:ignore-event-lines into f4d8e6bdb825ca2fb9ecec9aa8983f833980b6a5 on QubitProducts:master.

xperimental commented 7 years ago

Updated after merging #226. I removed the t.Parallel() again because I had tests which should fail be successful, it seems like my guess that it should be ok with parallelizing httptest was wrong.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 39.265% when pulling d51c598f98b04667c5c9e060e93b4203488196fe on xperimental:ignore-event-lines into f4d8e6bdb825ca2fb9ecec9aa8983f833980b6a5 on QubitProducts:master.

xperimental commented 7 years ago

Updated again, this time with a fix for the parallel tests. Turns out it was not an issue with httptest but rather with me not reading the documentation properly.

lclarkmichalek commented 7 years ago

Thanks :)

j1n6 commented 7 years ago

🌮

xperimental commented 7 years ago

You're welcome. Thanks for merging.