search

QubitProducts / bamboo

HAProxy auto configuration and auto service discovery for Mesos Marathon
Apache License 2.0
794 stars 215 forks source link

Support systemd in deb package #232

Closed turb closed 6 years ago

turb commented 7 years ago

Hello,

For now, the apt build uses a symbolic link to upstart in order to manage itself as a service.

I am not very familiar with upstart, as Debian is now based on systemd. Should it be meaningful to provide a systemd definition in the deb package?

If you are ok with this, I can provide a PR, the fpmoption being --deb-systemd FILEPATH.

(btw, it seems that go get only returns Bamboo 0.2.20, not the latest 0.2.21)

j1n6 commented 7 years ago

This sounds good. Supporting systemd is the way to go.

Happy to accept PR and fix the version issues.

On Feb 16, 2017, at 13:04, S. Veyrié notifications@github.com wrote:

Hello,

For now, the apt build uses a symbolic link to upstart in order to manage itself as a service.

I am not very familiar with upstart, as Debian is now based on systemd. Should it be meaningful to provide a systemd definition in the deb package?

If you are ok with this, I can provide a PR, the fpmoption being --deb-systemd FILEPATH.

(btw, it seems that go get only returns Bamboo 0.2.20, not the latest 0.2.21)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.