Closed Willbern closed 7 years ago
Thanks for the PR. @Willbern would you be able to resolve the git conflicts?
@activars ok
@activars Thanks for your review. I had resolved the git conflicts and add some unit test, but how to trigger the checks to run again manually?
Your commit triggers the test automatically.
@activars i have update the commit, but it does't run yet
There might be a test queue, I think it just managed to run and passed the test.
On Jun 29, 2017, at 14:08, Will notifications@github.com wrote:
@activars i have update the commit, but it does't run yet
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Yeah, the test passed and thanks for your reply.
When craeting an app with with docker macvlan network in marathon,there is two steps we may do bellow: reference: https://docs.docker.com/engine/userguide/networking/get-started-macvlan/
create docker macvlan network
deploy an app with json
{ "id": "macvlan-2048", "cmd": null, "cpus": 0.1, "mem": 128, "disk": 0, "instances": 1, "container": { "docker": { "image": "", "network": "HOST", "parameters": [ { "key": "net", "value": "macvlan0" } ] }, "type": "DOCKER" }, "ipAddress":{ "discovery":{ "ports":[ { "number":80, "name":"http", "protocol":"tcp" } ] } } }
this PR add IpAddress field and update the createApps function to support app with macvlan network