QubitProducts / bamboo

HAProxy auto configuration and auto service discovery for Mesos Marathon
Apache License 2.0
794 stars 215 forks source link

Does Bamboo support zookeeper authentication? #243

Open mrz001 opened 6 years ago

mrz001 commented 6 years ago

I have seen Mesos support ZK authentication like zk://username:password@host1:port1,host2:port2,.../path and Marathon suppoer ZK authentication like zk://user@pass:host1:port1,user@pass:host2:port2,.../path. How about Bamboo BAMBOO_ZK_HOST?

j1n6 commented 6 years ago

That should work.

On 17 Oct 2017, at 08:06, mrz001 notifications@github.com wrote:

I have seen Mesos support ZK authentication like zk://username:password@host1:port1,host2:port2,.../path and Marathon suppoer ZK authentication like zk://user@pass:host1:port1,user@pass:host2:port2,.../path. How about Bamboo BAMBOO_ZK_HOST?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

mrz001 commented 6 years ago

How to set BAMBOO_ZK_HOST?

j1n6 commented 6 years ago

it would be the same format:

zk://username:password@host1:port1,host2:port2,.../path
mrz001 commented 6 years ago

I have set BAMBOO_ZK_HOST=dcos:dcos@172.24.4.112:2181,172.24.4.113:2181,172.24.4.114:2181 , but it still shows "zk: not authenticated".

mrz001 commented 6 years ago

I find there is a TODO list in bamboo/configuration/zookeeper.go .

package configuration

import ( "strings" "time" )

/ Zookeeper configuration set / type Zookeeper struct { // comma separated host:port connection strings set Host string // zookeeper path Path string // Delay n seconds to report change event ReportingDelay int64

// TODO: authentication parameters for zookeeper

}

func (zk Zookeeper) Delay() time.Duration { return time.Duration(zk.ReportingDelay) * time.Second }

func (zk Zookeeper) ConnectionString() []string { return strings.Split(zk.Host, ",") }