QubitProducts / bamboo

HAProxy auto configuration and auto service discovery for Mesos Marathon
Apache License 2.0
793 stars 214 forks source link

Provide a string replace function for template renderer #27

Closed j1n6 closed 9 years ago

apriendeau commented 9 years ago

@activars are you talking about something like this?

reqrep ^([^\\ ]*\\ /)[a-zA-Z0-0\\-\\_]*[/]?(.*)    \\1\\2

I think this should be an option. Thoughts??

j1n6 commented 9 years ago

thanks for the suggestion. I think the initial thought was providing a regex replacement function can be used in template. It allows replacing identifier used in Marathon to something that Haproxy can handle. I would like to hold this feature because Marathon 0.7.4 introduced app versioning with healthchecks, a proper way to handle this may related to versioning.

apriendeau commented 9 years ago

So the use case that we had, was to take /app1/ but send it to / which is why I was asking if that if this was related to that because it would be nice to send that through API. I didn't want to create a duplicate issue.

j1n6 commented 9 years ago

yup - it certainly can be used for this scenario.

j1n6 commented 9 years ago

closed by #115