search

QubitProducts / bamboo

HAProxy auto configuration and auto service discovery for Mesos Marathon
Apache License 2.0
793 stars 214 forks source link

support multiple marathon URLs #40

Closed rasputnik closed 10 years ago

rasputnik commented 10 years ago

Fixes #35 - more optimization possible, but this is the basic support.

j1n6 commented 10 years ago

Thanks for the PR! I will review it very soon!

rasputnik commented 10 years ago

Don't mean to nag but any idea when you'll get a chance to take a look?

I'm going to need to spin some RPMs for our preprod. env. probably early next week - I could do it off my fork but it'd be good if it were from the main repo.

Cheers!

j1n6 commented 10 years ago

I'm ok with this initial feature introduction by this PR - just worry about when things running in scale the range won't help with the redundant requests.

It would be good to refactor the liveness check to a separate generic module and auto updates the configuration across the app. Such internal improvement shouldn't affect any compatibility issues, so i'm happy with merging. :)

Thanks for the contribution.