Minor optimization for Cherrytree.dispatch

QubitProducts / cherrytree

A flexible nested router.

MIT License

108 stars 20 forks source link

Closed blikblum closed 7 years ago

blikblum commented 7 years ago

This PR does the following optimizations:

Returns pathname in match and use alongside the dispatch code path preventing Path.withoutQuery being called more than once
Use some instead of forEach in match to break loop earlier and allow remove of found var

swagatha-christie commented 7 years ago

By analyzing the blame information on this pull request, we identified @KidkArolis, @nathanboktae and @oliverwoodings to be potential reviewers

KidkArolis commented 7 years ago

Some is not available in IE8, but who cares, am i right?

blikblum commented 7 years ago

Many thanks