search

QubitProducts / exporter_exporter

A reverse proxy designed for Prometheus exporters
Apache License 2.0
344 stars 55 forks source link

Expose list of configured exporters #16

Closed ldaneliukas closed 5 years ago

ldaneliukas commented 6 years ago

PR for #15

image

tdabasinskas commented 5 years ago

Hi, @tcolgate ,

Were you able to look into this PR? Just curious if this project is still alive 🙂

tcolgate commented 5 years ago

Hi, very sorry I missed this. This looks like a great idea. I put a comment on the PR, basically, probably better to either escape the text with whatever html/template uses, or use html/template directly.

ldaneliukas commented 5 years ago

Hey, @tcolgate - glad to see this is still maintained, we're quite heavy users of it :)

Is the PR good now?

ldaneliukas commented 5 years ago

Update the PR. There's also quite a few of go.mod changes, due to go mod tidy, I hope that's okey.

tcolgate commented 5 years ago

The PR is showing conflicts, I'm just trying to rebase locally.

ldaneliukas commented 5 years ago

Rebased the fork against upstream

tcolgate commented 5 years ago

Great, sorry that got a bit painful, the PR was trying to rip out a bunch of fixes. Thanks, this is a really nice addition.

candlerb commented 5 years ago

Any chance of a new binary release? This change was merged shortly after v0.2.9 was released. Thanks!

tcolgate commented 5 years ago

I'll look into this on Monday.

On Sat, 19 Oct 2019, 10:03 Brian Candler, notifications@github.com wrote:

Any chance of a new binary release? This change was merged shortly after v0.2.9 was released. Thanks!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/QubitProducts/exporter_exporter/pull/16?email_source=notifications&email_token=AAASR44L2ESO6IXFC5RDU5LQPLEOZA5CNFSM4FYPE23KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXJI7Y#issuecomment-544117887, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASR476H7SNR5GQ6YUMESTQPLEOZANCNFSM4FYPE23A .