search

QubitProducts / exporter_exporter

A reverse proxy designed for Prometheus exporters
Apache License 2.0
336 stars 55 forks source link

add http access logging #40

Closed cyril-s closed 4 years ago

cyril-s commented 4 years ago

Add http access logging

tcolgate commented 4 years ago

I think access logging everything at Info might be too much of a change of behaviour, and whilst non-200s aren't strictly an error with expexp, I do think it would be reasonable to error log them from the PoV of a user actually debugging failed scrapes.

cyril-s commented 4 years ago

@tcolgate added -log.level and -log.json flags. Access logging goes under info level. Default is warning. Errors from exp exp while trying to proxy http go under error. What do you think?

tcolgate commented 4 years ago

Cool, thanks, that looks good enough.

tcolgate commented 4 years ago

Thanks for you're contributions and efforts, they are very much appreciated. We don't make much of of expexp internally anymore, but it does get reasonable interest and use in the community, so I'm happy to keep maintaining it. Without your efforts it would be pretty stale by now.