search

QubitProducts / exporter_exporter

A reverse proxy designed for Prometheus exporters
Apache License 2.0
345 stars 55 forks source link

Windows service support #43

Closed ldaneliukas closed 4 years ago

ldaneliukas commented 4 years ago

Fixes #20

Tested the ability to install, uninstall, start and stop the Windows service on:

tcolgate commented 4 years ago

Once this is merged, I'll do a release.

tcolgate commented 4 years ago

Is it worth having something in the README about how to go about setting this up?

ldaneliukas commented 4 years ago

Definitely, I'll push it later on today. Though can we hold off on the release a little bit? I'd like to add a build for Nuget (could potentially be shipped to Chocolatey) to go along with the Windows service (separate PR).

tcolgate commented 4 years ago

Though can we hold off on the release a little bit? I'd like to add a build for Nuget (could potentially be shipped to Chocolatey) to go along with the Windows service (separate PR).

Happy to hold off on the release, You'd probably be shocked at the degree to which that second sentence makes no sense to me! :smile:

tcolgate commented 4 years ago

Thank you very much. This is a very welcome contribution, and not one we would have implemented ourselves.

ldaneliukas commented 4 years ago

Though can we hold off on the release a little bit? I'd like to add a build for Nuget (could potentially be shipped to Chocolatey) to go along with the Windows service (separate PR).

Happy to hold off on the release, You'd probably be shocked at the degree to which that second sentence makes no sense to me! smile

I know what you mean, just getting the hang of all these Windows things :nerd_face: