Refactor Dockerfile for better build caching

QubitProducts / exporter_exporter

A reverse proxy designed for Prometheus exporters

Apache License 2.0

344 stars 55 forks source link

Refactor Dockerfile for better build caching #69

Closed AKarbas closed 3 years ago

AKarbas commented 3 years ago

Also:

Bumped build go version in Dockerfile.
~~Specified image versions and sha256 tags explicitely.~~

AKarbas commented 3 years ago

Also please push a new image. The latest tag is currently on 0.2.6. (link)

tcolgate commented 3 years ago

I'd entirely forgotten that we ever pushed to docker hub TBH. I've pushed an update to 0.4.2, and we can update make to include it in the release process.

AKarbas commented 3 years ago

Cool. Please also update the latest tag.

steinbrueckri commented 3 years ago

any update on this?

tcolgate commented 3 years ago

Sorry, I've been off on leave. I'm not actually keen on fixing the SHA sums for the images TBH. I'd rather get the updates with the base OK when we release. The file copy changes make sense.

AKarbas commented 3 years ago

I'm not actually keen on fixing the SHA sums for the images TBH. I'd rather get the updates with the base OK when we release. The file copy changes make sense.

Alright, so specific version for GoLang and latest for alpine? Or latest for both?

tcolgate commented 3 years ago

Specific major release for golang I think (e.g. 1.16), and latest of alpine.

tcolgate commented 3 years ago

Thanks for the contribution, and my apologies for the delays.