search

QubitProducts / exporter_exporter

A reverse proxy designed for Prometheus exporters
Apache License 2.0
345 stars 55 forks source link

ARM Release #73

Closed steinbrueckri closed 3 years ago

steinbrueckri commented 3 years ago

Hi *, I need for a project an ARM release, can you adjust the build and also build an ARM binary on every release?

Cheers 🍻 Richard

tcolgate commented 3 years ago

Happy to take a PR, the builds are fiddly enough that I'd need to spend a while testing this so can't loo into it at the moment. Building manually is easy, and cross compiling for arm should just require a GOARCH=... . Presumably this is really only useful on linux at the moment?

steinbrueckri commented 3 years ago

@tcolgate THX for the fast feedback. I know that I can build for my own but that's not a proper solution, I will do my best to provide a PR. The only place is the Makefile correct? Any other hints from your side?

Cheers 🍻 Richard

tcolgate commented 3 years ago

Correct, all the release stuff is in the Makefile. I think it used to rely on some GNU make specific bits, but that may not be the case anymore (been revised a few times).

steinbrueckri commented 3 years ago

@tcolgate PR is open, it's not really pretty but it works at least maybe in the future we should take a look at task for an easier and maintainable build system. 😅