search

QubitProducts / exporter_exporter

A reverse proxy designed for Prometheus exporters
Apache License 2.0
332 stars 55 forks source link

update golang and dependencies #85

Closed dallemon closed 1 year ago

dallemon commented 1 year ago

this pr refactors dockerfile, updates golang to 1.19 and fixes broken packages related to the update.

tcolgate commented 1 year ago

The Dockerfile changes seem largely cosmetic, and I'd rather not fix the alpine version (since that then requires explicit maintenance for security fixes for alpine.

dallemon commented 1 year ago

made the requested change.

tcolgate commented 1 year ago

Personally I'd probably rather go with klog than logrus for logging. Any specific reason you opted for logrus?

dallemon commented 1 year ago

Personally I'd probably rather go with klog than logrus for logging. Any specific reason you opted for logrus?

It was already in use in the project. :)

tcolgate commented 1 year ago

Thanks, and sorry for the slow review.