search

Qucs / ADMS

ADMS is a code generator for the Verilog-AMS language
GNU General Public License v3.0
94 stars 32 forks source link

Support for rotational_omega discipline #58

Closed mirandadam closed 4 years ago

mirandadam commented 7 years ago

Hi, I would like to model a motor using ADMS and it seems ADMS/admsXml/disciplines.vams does not fully support the rotational_omega discipline with the basic Omega and Theta accessors as in http://verilogams.com/refman/basics/disciplines.html and http://accellera.org/downloads/standards/v-ams (page 391 of the 2.4 reference).

The disciplines.vams file has "FIXME" comments next to the rotational_omega definition. I figure one could use "V" instead of "Omega" and "I" (capital i) instead of "Theta" as things are right now.

felix-salfelder commented 7 years ago

How can I help?

please file a PR with the suggested change. it sounds reasonable.

mirandadam commented 7 years ago

I don't have a suggested change yet... :-) I will try just updating the disciplines.vams file and seeing what happens. If it works, I will submit a proper P.R.

By the way, thanks for helping maintaining this great project!

felix-salfelder commented 4 years ago

the discipline header included with adms is a minimal version, stripped down due to copyright. but there is no issue, as it is possible to use customized headers where needed. (still, feel free to send patches).

mirandadam commented 4 years ago

Sorry for leaving this open for so long. I have stopped working on the motor simulation long ago. Good thing you closed the issue.