search

Qucs / ADMS

ADMS is a code generator for the Verilog-AMS language
GNU General Public License v3.0
94 stars 32 forks source link

Remove the Maintainer mode #79

Closed ricardofantin closed 6 years ago

ricardofantin commented 6 years ago

The maintainer option which default value was false have been removed. Now it is how the user always pass the maintainer_options as on/true/yes. Two bugs are closed with this pull request: #57 and #63 . The first bug is about download the adms...tar.gz and type make two times with the autotools build, this way the second make doesn't finish complying about a missing file. In the second bug the user forget to include -DUSE_MAINTAINER_MODE=ON which generates a build error.

One draw back of this implementation is that the perl should be always available. If you are building in Windows, it could be a disadvantage. But I think the advantages are much better than the disadvantage.

The documentation were also update. I don't change anything in the changelog.

I'm here and will try to correct anything pointed to be changed.

felix-salfelder commented 6 years ago

thanks, very good move.

perhaps Guilherme should check the changes to the cmake files, the others look good to me.

NB: "Jim Meyering, the inventor of the AM_MAINTAINER_MODE macro was swayed by François’s arguments, and got rid of AM_MAINTAINER_MODE in all of his packages." see https://www.gnu.org/software/automake/manual/html_node/maintainer_002dmode.html

guitorri commented 6 years ago

It should go into develop branch. I will try to change on the PR.