Remove stray assignments which prevent running on Linux

Qucs / qucs-test

Qucs Project test suite and scripts repository

5 stars 14 forks source link

Remove stray assignments which prevent running on Linux #15

Closed in3otd closed 8 years ago

in3otd commented 8 years ago

sorry, but the previous PR still contained some leftover code from previous attempts to make it work on WIndows; I have just realized that this causes some errors on Linux, so here is a fix/cleanup.

This time I have checked that the same code runs on both Linux and Windows...

felix-salfelder commented 8 years ago

seems plausible.

i don't know how to easily run CI on PRs to qucs-test before merge. i think there's no harm involved, as it will have to get past qucs/qucs CI anyway.

(yes, my previous review was sloppy, just like this one ..)

in3otd commented 8 years ago

well, with sloppy code a sloppy review is fine :grin:

I guess we could enable Travis and AppVeyor also on qucs-test... if we had time