Qucs / qucs

Qucs Project official mirror
http://qucs.sourceforge.net/
GNU General Public License v2.0
1.16k stars 213 forks source link

Instead of fixed numbers, use an enum. So the code gets more readable #1028

Closed Murmele closed 3 years ago

felix-salfelder commented 3 years ago

I think I commented on the preprocessor macro somewhere turn it into a static function.

this

m_model->item(FileTypes_T::Datasets, 0)->appendRow(columnData);

is known as the "train wreck" anti pattern. pointers must be checked before dereferencing (e.g. in function).

Murmele commented 3 years ago

Ok good to know I will change it

Murmele commented 3 years ago

@felix-salfelder now I'm checking if the item is available or not.